Re: Adjust error message for CREATE STATISTICS to account for expressions

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adjust error message for CREATE STATISTICS to account for expressions
Date: 2026-03-30 03:21:54
Message-ID: CANWCAZaYOdb7p=xndzgDfvJ-0NN_HTyx54LVUX2i1Xs7cPSzbw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 28, 2026 at 1:04 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> On Fri, 27 Mar 2026 09:50:07 +0000
> Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:

> > If we were to give more detail, it should probably be to point out
> > that regular statistics will already be built for single columns,
> > which is why single-column extended statistics would be redundant. So
> > perhaps something like this:
> >
> > Error: cannot create extended statistics on a single column
> > Detail: Univariate statistics are already built for each individual
> > table column.
>
> That makes sense to me.
>
> Using an errdetail to explain the reason sounds reasonable.

Works for me.

> > > On Fri, 27 Mar 2026 07:45:37 +0700
> > > John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> > > > Looking elsewhere in this file, however, I
> > > > do see some messages with "cannot do X because ....", and I'd be more
> > > > motivated to turn those "because" phrases into errdetails.

Did you also want to try tackling this while we're here?

--
John Naylor
Amazon Web Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2026-03-30 03:34:56 Re: [PATCH] Report column-level error when lacking privilege
Previous Message David Rowley 2026-03-30 03:20:33 Re: Fix "could not find memoization table entry"