Re: BUG: test_ginpostinglist second itemptr check is a no-op due to copy-paste error

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Jianghua Yang <yjhjstz(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: BUG: test_ginpostinglist second itemptr check is a no-op due to copy-paste error
Date: 2026-03-24 10:30:14
Message-ID: CANWCAZZbjetZPb8XhCvNRNo8Ji_qaowq1VT4hhyoLiBAGaJo3w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 24, 2026 at 8:59 AM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Tue, Mar 24, 2026 at 8:45 AM Jianghua Yang <yjhjstz(at)gmail(dot)com> wrote:
> > The attached patch fixes the second check to compare orig_itemptrs[1]
> > with decoded_itemptrs[1] and reports (blk, off) as the expected
> > value in the error message.
>
> Seems right to me, thanks for the patch. I'll take care of this.

This is done. It seems unlikely that this test would need to be
changed in back branches, but I went ahead and backpatched it anyway
just in case.

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-03-24 10:45:55 Re: TupleDescAttr bounds checks
Previous Message Yugo Nagata 2026-03-24 10:25:37 Re: Add a berief general comment on BTScanInsertData's nextkey and backward