| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Update EnableTimeoutParams timeout type comment |
| Date: | 2026-07-01 04:01:04 |
| Message-ID: | CANWCAZYiei++PhiCOVLGLhb87J6OitMgNOJAPA6TSo_THmPsrw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 1, 2026 at 8:44 AM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
> While reading the timeout code, I noticed that the comment for
> EnableTimeoutParams timeout type is kinda stale. Currently, we support
> three types of timeout TMPARAM_AFTER/AT/EVERY, but the comment only
> mentions the first two. It may not cause confusion, since the two
> structs are adjacent, but it might still be worth making this clearer.
> Attached a patch to update it.
It seems pointless to have a comment whose entire content is to list
every current enum member of that type. I'd just delete the comment,
since it's likely to just going to get outdated again. If any other
objects of type enum have this, they should get the same treatment.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-07-01 04:17:29 | Re: Add pg_stat_kind_info system view |
| Previous Message | Bertrand Drouvot | 2026-07-01 03:39:37 | Re: Add pg_stat_kind_info system view |