| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Mario González Troncoso <gonzalemario(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com> |
| Subject: | Re: [PATCH} Move instrumentation structs |
| Date: | 2026-01-13 11:54:03 |
| Message-ID: | CANWCAZYBNjR6vvPuBBVT37P3yEUiGoY=KFSPo740QVoyk8QzUQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 13, 2026 at 6:38 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Jan-13, David Rowley wrote:
>
> > There's a bit of conflicting opinion going on here with the changes
> > made in 128897b101e0.
> Sounds about right, though I think we can shave some words off that.
> How about
>
> int64 maxSpace; /* maximum amount of space occupied among sort
> * of groups, either in-memory or on-disk */
> bool isMaxSpaceDisk; /* true when maxSpace tracks on-disk space, false
> * means in-memory */
> ?
>
> (CCed Jacob as author and John as committer of that change, in case they
> care to comment.)
Hmm, yeah, that commit wasn't quite enough to make that phrase clear,
but I don't remember the interpretation.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2026-01-13 12:10:20 | Re: Optimize LISTEN/NOTIFY |
| Previous Message | John Naylor | 2026-01-13 11:38:51 | Re: pg_plan_advice |