RULE regression test fragility?

From: Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>
To: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: RULE regression test fragility?
Date: 2013-10-23 16:40:54
Message-ID: CANPAkgunoTdgoJEvagr-+Rd0ABtbjywybYBnY6gNs7f_1HkaJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While reviewing the Network Stats Traffic patch I discovered the current
regression test for rules depends on the system view definitions not
changing:

--
-- Check that ruleutils are working
--
SELECT viewname, definition FROM pg_views WHERE schemaname <>
'information_schema' ORDER BY viewname;

In this particular case new fields have been added to the view, breaking
this apparently unrelated test. Is checking the definition of all views
necessary for this test? Would it possibly be better to create a temporary
view for this check, or is something else going on here?

​​
__________________________________________________________________________________
*Mike Blackwell | Technical Analyst, Distribution Services/Rollout
Management | RR Donnelley*
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike(dot)Blackwell(at)rrd(dot)com
http://www.rrdonnelley.com

<http://www.rrdonnelley.com/>
* <Mike(dot)Blackwell(at)rrd(dot)com>*

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-10-23 16:45:23 Re: Commitfest II CLosed
Previous Message Sameer Kumar 2013-10-23 16:37:42 Re: Using indexes for ORDER BY and PARTITION BY clause in windowing functions