Re: pgsql: Fix precedence problem in new Perl code.

From: Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix precedence problem in new Perl code.
Date: 2018-05-04 14:30:05
Message-ID: CANPAkgtJL8KbY1c9nyuAkfLjZYSUhU9zM2xWgLgGDTvFggvJWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

In my experience, that would more commonly be written with the lower
precedence "or" operator (with or without the param list parens):

unlink $temp_name or die "unlink: $temp_name: $!";

__________________________________________________________________________________
*Mike Blackwell | Technical Analyst, Distribution Services/Rollout
Management | RRD*
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike(dot)Blackwell(at)rrd(dot)com
http://www.rrdonnelley.com

<http://www.rrdonnelley.com/>
* <Mike(dot)Blackwell(at)rrd(dot)com>*

On Fri, May 4, 2018 at 8:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Fix precedence problem in new Perl code.
>
> I think this bit of commit 1f1cd9b5d didn't do quite what I meant :-(
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/59cb323053f4ed582d4e71acaeb577
> 0603f074db
>
> Modified Files
> --------------
> src/backend/catalog/Catalog.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-05-04 15:19:01 Re: pgsql: Fix precedence problem in new Perl code.
Previous Message Tom Lane 2018-05-04 13:46:47 pgsql: Fix precedence problem in new Perl code.

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-05-04 14:43:19 Re: Allow reload recovery.conf during recovery
Previous Message Sergei Kornilov 2018-05-04 14:19:26 Allow reload recovery.conf during recovery