Re: Bug in two-phase transaction recovery

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in two-phase transaction recovery
Date: 2016-09-09 12:24:02
Message-ID: CANP8+jLvb+637uQU8gNo7keH7pUuSS+pu3E82sqkdKeqKZQD9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8 September 2016 at 11:18, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 8 September 2016 at 07:43, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Wed, Sep 7, 2016 at 10:48 PM, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
>>> Some time ago two-phase state file format was changed to have variable size GID,
>>> but several places that read that files were not updated to use new offsets. Problem
>>> exists in master and 9.6 and can be reproduced on prepared transactions with
>>> savepoints.
>>
>> Oops and meh. This meritates an open item, and has better be fixed by
>> 9.6.0. I am glad you noticed that honestly. And we had better take
>> care of this issue as soon as possible.
>
> Looking now.

Committed, thanks.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2016-09-09 12:25:29 Re: Tuplesort merge pre-reading
Previous Message Michael Paquier 2016-09-09 12:13:55 Re: [COMMITTERS] pgsql: Fix corruption of 2PC recovery with subxacts