| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Madan Kumar <madankumar1993(at)gmail(dot)com>, "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, soumyadeep2007(at)gmail(dot)com |
| Subject: | Re: A patch for get origin from commit_ts. |
| Date: | 2020-07-02 07:52:45 |
| Message-ID: | CANP8+jLoY1ZyWP1KeqetGTettwmiBpk1jdjwQ2x+MFMauc201A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2 Jul 2020 at 02:58, <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jun 30, 2020 at 01:58:17PM +0100, Simon Riggs wrote:
> > On Tue, 30 Jun 2020 at 02:17, Madan Kumar <madankumar1993(at)gmail(dot)com>
> wrote:
> >> It may be better to have one single function returning both
> >> timestamp and origin for a given transaction ID.
> >
> > No need to change existing APIs.
>
> Adding a new function able to return both fields at the same time does
> not imply that we'd remove the original one, it just implies that we
> would be able to retrieve both fields with a single call of
> TransactionIdGetCommitTsData(), saving from an extra CommitTsSLRULock
> taken, etc. That's actually what pglogical does with
> its pglogical_xact_commit_timestamp_origin() in
> pglogical_functions.c. So adding one function able to return one
> tuple with the two fields, without removing the existing
> pg_xact_commit_timestamp() makes the most sense, no?
>
OK
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
Mission Critical Databases
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2020-07-02 08:12:02 | Re: A patch for get origin from commit_ts. |
| Previous Message | James Sewell | 2020-07-02 06:39:22 | Re: Threading in BGWorkers (!) |