Re: Logical Replication and triggers

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Rosenstein <thomas(dot)rosenstein(at)creamfinance(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical Replication and triggers
Date: 2017-11-22 05:34:27
Message-ID: CANP8+jLYarPhRKVUtrk2sHpd1JNmns+rT+6-+k9RKnbQKu3JEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22 November 2017 at 08:35, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Nov 21, 2017 at 4:28 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> I would have acted on this myself a few days back if I thought the
>> patch was correct, but I see multiple command counter increments
>> there, so suspect an alternate fix is correct.
>
> Oh, well, I'm glad you said something. I was actually thinking about
> committing the patch Peter posted in
> http://postgr.es/m/619c557d-93e6-1833-1692-b010b176ff77@2ndquadrant.com
> because it looks correct to me, but I'm certainly not an expert on
> that code so I'll wait for your analysis.

OK, I've re-reviewed it and found it good, so have committed it.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2017-11-22 05:56:07 Re: Failed to delete old ReorderBuffer spilled files
Previous Message Simon Riggs 2017-11-22 05:32:33 Re: [HACKERS] Issues with logical replication