| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Álvaro Herrera <alvaro(dot)herrera(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Transaction traceability - txid_status(bigint) |
| Date: | 2017-03-22 07:13:32 |
| Message-ID: | CANP8+jLYNHdgtqp2vJmAtkJc7RYebqFm1twGSLjkrrbV_L_9-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22 March 2017 at 03:35, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 22 March 2017 at 09:49, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>
>>> Overall, though, I think that 0001 looks far better than any previous
>>> iteration. It's simple. It looks safe. It seems unlikely to break
>>> anything that works now. Woo hoo!
>>
>> Funny that this started with "hey, here's a simple, non-invasive
>> function for looking up the status of an arbitrary xid".
>
> Changes made per discussion.
This looks good to me also. Does what we need it to do.
I was a little worried by possible performance of new lock, but its
not intended to be run frequently, so its OK.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-03-22 07:18:59 | [PATCH] Reduce src/test/recovery verbosity |
| Previous Message | Kyotaro HORIGUCHI | 2017-03-22 07:09:25 | Re: Create replication slot in pg_basebackup if requested and not yet present |