| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Subject: | Re: LSN as a recovery target |
| Date: | 2016-08-23 09:10:54 |
| Message-ID: | CANP8+jLE_xCWnv_=goiyWPfqiSPd_pPjdaagXH74xJAgYyijWw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23 August 2016 at 09:39, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> Looks very reasonable to me (both patches). Thanks for doing that.
>
> I am inclined to mark this as ready for committer.
Looking at it now.
The messages for recovery_target_lsn don't mention after or before, as
do other targets... e.g.
recoveryStopAfter ? "after" : "before",
My understanding is that if you request an LSN that isn't the exact
end point of a WAL record then it will either stop before or after the
requested point, so that needs to be described in the docs and in the
messages generated prior to starting to search.
Everything else looks in good order.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-08-23 09:27:02 | Re: [PATCH] Transaction traceability - txid_status(bigint) |
| Previous Message | Adrien Nayrat | 2016-08-23 09:05:52 | Re: LSN as a recovery target |