| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Date: | 2015-05-27 13:20:58 |
| Message-ID: | CANP8+jKkDv7Mx=2+RLNJx+KZ1QLUtUJT-NoX=ci=H6ddT-NtUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 22 May 2015 at 00:28, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > On the other hand, this was noticed because Alvaro just argued that it
> > *should* have a new command tag. Alvaro, where do you see the advantage?
>
> Well, I was just skimming nearby code and noticed that CreateCommandTag
> hadn't been updated. As I said elsewhere, I'm not even running
> commands. I'm not really set on having the tag be different.
>
I agree with Alvaro that we need to be able to see a difference.
I also agree with Tom/Robert that we should not invent a new tag.
What I think should happen is that the command tag should vary according to
whether an INSERT or an UPDATE was performed, so we get a visible
difference without any new tags.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-05-27 13:24:29 | Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension |
| Previous Message | Amit Kapila | 2015-05-27 10:48:29 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-05-27 13:24:29 | Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension |
| Previous Message | Michael Paquier | 2015-05-27 13:10:20 | Re: BUG #13126: table constraint loses its comment |