Re: Minor typo in partition.c

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor typo in partition.c
Date: 2017-04-15 11:39:43
Message-ID: CANP8+jJpTBgf9XuD9GY1_v7NHDisH9fNrZDFBh3s9yraHX2ZOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14 April 2017 at 09:18, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:

>> Where shall I mention BRIN in that chapter?
>
> Maybe just append a new <sect2> right below where <sect2
> id="ddl-partitioning-constraint-exclusion"> ends?
>
> I had included both BRIN and UNION ALL views under a sub-section titled
> "Alternative Methods" in my original patch (March 3rd one), but removed
> the whole sub-section per review comments. Perhaps, my patch didn't do a
> good enough job of describing either BRIN or UNION ALL views, that it
> ended up being not convincing enough to be made part of the section.
>
> By the way, will you also be adding details on UNION ALL views (I remember
> you said you would along with BRIN)? Actually, my patch copied verbatim
> what older docs had about them that you said is too short a description.

It makes sense to describe all similar techniques in one section of the docs.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-04-15 13:29:53 Re: Cutting initdb's runtime (Perl question embedded)
Previous Message Simon Riggs 2017-04-15 11:38:23 Re: Minor typo in partition.c