| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | pgbench MAX_ARGS |
| Date: | 2019-02-26 09:41:02 |
| Message-ID: | CANP8+jJiMJOAf-dLoHuR-8GENiK+eHTY=Omw38Qx7j2g0NDTXA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
pgbench has a strange restriction to only allow 10 arguments, which is too
low for some real world uses.
Since MAX_ARGS is only used for an array of pointers and an array of
integers increasing this should not be a problem, so increase value to 255.
While there, correct an off by one error in the error message when you hit
the limit. The highest argument id is MAX_ARGS - 1, but the max number of
arguments is MAX_ARGS.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench_maxargs.v1.patch | application/octet-stream | 605 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-02-26 10:20:00 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Amit Kapila | 2019-02-26 09:28:22 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |