| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
| Date: | 2018-03-23 11:06:48 |
| Message-ID: | CANP8+jJVcxM-S7U2sf9O2CEBDVg73hQnaHRssNQ2RMfi4_BtSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23 March 2018 at 09:22, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Mar 23, 2018 at 09:04:55AM +0000, Simon Riggs wrote:
>> So it shows clear benefit for both bulk actions and OLTP, with no regressions.
>>
>> No objection exists to the approach used in the patch, so I'm now
>> ready to commit this.
>>
>> Last call for objections?
>
> Please hold on. It is Friday evening here. First I cannot take the
> time to articulate an answer you are requesting on the other thread
> part. Second, the latest version of the patch has been sent from Pavan
> a couple of hours ago, and you are proposing to commit it in a message
> sent 29 minutes after the last version has been sent.
>
> Let's cool down a bit and take some time for reviews, please. You still
> have one week until the end of the commit fest anyway.
Your assumption that I would commit a new patch that was 29 mins old
is frankly pretty ridiculous, so yes, lets keep calm.
Enjoy your weekend and I'll be happy to read your review on Monday.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2018-03-23 11:07:52 | Re: [HACKERS] MERGE SQL Statement for PG11 |
| Previous Message | Jeevan Chalke | 2018-03-23 11:05:59 | Re: [HACKERS] Partition-wise aggregation/grouping |