Re: pgsql: Generational memory allocator

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Generational memory allocator
Date: 2017-11-26 21:17:47
Message-ID: CANP8+jJTVM+mVTwgKXh5T-v3oV3RsXZ5Nu-5S+UF5b+pqSARpA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 27 November 2017 at 06:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
>> On 27 November 2017 at 05:53, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Well, let's not overthink this, because anything under 8K is going to
>>> be rounded up to the next power of 2 anyway by aset.c. Based on this
>>> point I'd say that BLCKSZ/2 or BLCKSZ/4 would be reasonable candidates
>>> for the minimum.
>
>> BLCKSZ/2 seems best then.
>
> Sold, will make it so.

So you will like this next patch also, since there is related code
above that stanza.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
data_bufsz.v1.patch application/octet-stream 745 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-11-26 22:06:11 Re: pgsql: Generational memory allocator
Previous Message Tom Lane 2017-11-26 20:17:42 pgsql: Pad XLogReaderState's main_data buffer more aggressively.