| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. ); |
| Date: | 2015-07-31 13:05:33 |
| Message-ID: | CANP8+j+wwvGvXgRHmuwEUymhAGXY1+ZC8SMu+u6kvK9OwsPsQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31 July 2015 at 02:46, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Added. I really don't know if my isolation tests are completely correct,
> is
> > my first time writing this kind of tests.
>
> This patch size has increased from 16k to 157k because of the output
> of the isolation tests you just added.
That's too much.
Why do we need more isolation tests? There isn't anything critical here,
its just different lock levels for ALTER TABLE. A few normal regression
tests are fine for this.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2015-07-31 13:09:52 | Re: creating extension including dependencies |
| Previous Message | Michael Paquier | 2015-07-31 13:04:28 | Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. ); |