From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: use foreign keys to improve join estimates v1 |
Date: | 2016-04-04 08:25:41 |
Message-ID: | CANP8+j+aXw2_RbQKL1va5YvH=12rE=XT=kqFOwiCnouJjh4OnQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3 April 2016 at 22:44, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Detailed comments in the planner part of the patch. The discussion around
> this patch isn't reflected enough in the patch.
>
I think we should record that the planner uses the constraint, even if the
constraint is not yet valid, per DDL.
The rel cache code you're adding uses a flag called "rd_fkeyvalid" which
indicates that the relcache is correctly filled. That is confusing, since
it has nothing to do with the concept of constraint validity. We should
rename that to rd_fkeycachefilled or similar.
ISTM that the FKey info added to the rel cache would be useful for many
optimizations, hence why I think we should commit that separately, whether
or not the specific optimization for the other half of the patch is
accepted or later modified or revoked. Objections?
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2016-04-04 08:28:07 | Re: Support for N synchronous standby servers - take 2 |
Previous Message | Simon Riggs | 2016-04-04 07:57:36 | Re: Proposal: Generic WAL logical messages |