| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Logical decoding slots can go backwards when used from SQL, docs are wrong |
| Date: | 2016-09-05 08:52:19 |
| Message-ID: | CANP8+j+_ThSAfOGd_LETqNWUa+5aeoA6KH3ubSrrL3cJ0bAupQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5 September 2016 at 03:41, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 2 September 2016 at 17:49, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>
>> So the main change becomes the one-liner in my prior mail.
>
> Per feedback from Simon, updated with a new test in src/test/recovery .
>
> If you revert the change to
> src/backend/replication/logical/logicalfuncs.c then the test will
> start failing.
>
> I'd quite like to backpatch the fix since it's simple and safe, but I
> don't feel that it's hugely important to do so. This is an annoyance
> not a serious data risking bug.
I've committed to HEAD only. We can discuss backpatching elsewhere also.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2016-09-05 09:03:45 | Re: Yet another small patch - reorderbuffer.c:1099 |
| Previous Message | Petr Jelinek | 2016-09-05 08:33:41 | Re: Logical decoding slots can go backwards when used from SQL, docs are wrong |