| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to improve performance of replay of AccessExclusiveLock |
| Date: | 2017-03-18 08:59:11 |
| Message-ID: | CANP8+j+_MMqpffRHqd1nf1Ppiap1eqMcVPP=mRiqQ_1FtCN24Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16 March 2017 at 09:52, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> Seemed easier to write it than explain further. Please see what you think.
>
>
> Thanks. I had been looking for some struct to store the flag in. I'd not
> considered just adding a new global variable.
As Amit says, I don't see the gain from adding that to each xact state.
I'd suggest refactoring my patch so that the existign
MyXactAccessedTempRel becomes MyXactFlags and we can just set a flag
in the two cases (temp rels and has-aels). That way we still have one
Global but it doesn't get any uglier than it already is.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2017-03-18 09:37:48 | Re: Two phase commit in ECPG |
| Previous Message | Simon Riggs | 2017-03-18 08:53:40 | Re: Patch to improve performance of replay of AccessExclusiveLock |