Re: pgsql: Generational memory allocator

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Generational memory allocator
Date: 2017-11-27 04:13:19
Message-ID: CANP8+j+LZNRt79coE_oV5L3kAtGCULkTGz59_DLvnt1F7tceaQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 27 November 2017 at 09:06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
>> On 27 November 2017 at 06:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Sold, will make it so.
>
>> So you will like this next patch also, since there is related code
>> above that stanza.
>
> Looks reasonable to me, but I wonder whether BLCKSZ is a good initial
> setting. Since the data length is only uint16, we're apparently assuming
> that the contents must be small.

Our max block size is 2^15 so I think we're good.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2017-11-27 08:32:02 pgsql: Fix typo in comment
Previous Message Tom Lane 2017-11-26 22:06:11 Re: pgsql: Generational memory allocator