Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()

On 24 March 2018 at 12:19, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Mar 24, 2018 at 8:11 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 24 March 2018 at 11:58, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Sat, Mar 24, 2018 at 7:42 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>>> I suggest we focus on the engineering. I've not discussed this patch
>>>> with Pavan offline.
>>>
>>> Well then proposing to commit moments after it's been posted is
>>> ridiculous. That's exactly the opposite of "focusing on the
>>> engineering".
>>>
>>> This is a patch about which multiple people have expressed concerns.
>>> You're trying to jam a heavily redesigned version in at the last
>>> minute without adequate review. Please don't do that.
>>
>> All presumption on your part. Don't tell me what I think and then diss
>> me for that.
>
> It is of course true that I can't know your internal mental state with
> certainty, but I don't think it is presumptuous to suppose that a
> person who says they're going to commit a patch that hasn't been
> reviewed intends to commit a patch that hasn't been reviewed.

It seems you really are more intent on talking about my actions than
on discussing the patch.

Probably would have been better to read what I've actually said beforehand.

If you have anything further to say, make it a formal complaint
offlist so we can discuss engineering here.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services