| From: | Mingli Zhang <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix incorrect function reference BufFileOpenShared in comment. |
| Date: | 2025-10-03 09:16:50 |
| Message-ID: | CANG7CA+v5OHuG8sZgybXEppkuzuLGBRcV3eihUEzD9EoX4_38Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks.
Richard Guo <guofenglinux(at)gmail(dot)com>于2025年10月3日 周五15:41写道：
> On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres(at)gmail(dot)com>
> wrote:
> > > The comment incorrectly cited the defunct function BufFileOpenShared()
> > > which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
> > >
> > > Update the reference to the current function: BufFileOpenFileSet().
>
> > Nice catch. Running `git grep 'BufFile.*Shared'` confirms that this
> > is the only place referencing the outdated BufFileXXXShared()
> > functions. I'll push this patch barring any objections.
>
> Pushed.
>
> - Richard
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-10-03 09:17:55 | Re: Clear logical slot's 'synced' flag on promotion of standby |
| Previous Message | Chengpeng Yan | 2025-10-03 09:10:35 | Re: Allow virtual columns in index expressions or predicate |