| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: meson: Make test output much more useful on failure (both in CI and locally) |
| Date: | 2026-02-03 10:20:26 |
| Message-ID: | CAN55FZ3w-3z=js-3We78P41heKCY1aOMsUz3p7UrQa7amGWL7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for working on this! I think this is a nice improvement.
On Tue, 27 Jan 2026 at 17:48, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> On Mon Jan 26, 2026 at 5:42 PM CET, Andres Freund wrote:
> > I agree that what we currently do is pretty unhelpful.
>
> Attached is v2, which I think fixes all the issues that you mentioned.
v2-0001:
This doesn't really read the first 80 lines of the combined diff.
Lines with more than 1023 characters will be counted and printed as
multiple lines. I don't think this is a problem but clearing this
would be helpful. Other than that, it looks good to me.
v2-0002:
I am just curious if test failure can cause file descriptors not being
properly closed and then the IPC::Run:run() call will hang
indefinitely like the pg_ctl case. Other than that, it looks good to
me.
v2-0003 and v2-0004 look good to me.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-02-03 10:21:48 | Re: [PATCH] Support automatic sequence replication |
| Previous Message | Bertrand Drouvot | 2026-02-03 09:49:41 | Get rid of the pre-C11 _Alignof define in zic.c |