Re: Improve docs syntax checking and enable it in the meson build

Hi,

On Wed, 29 Oct 2025 at 20:24, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 22.10.25 10:04, Nazir Bilal Yavuz wrote:
> > diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
> > index eca9d62fc22..1c937247a9a 100644
> > --- a/.cirrus.tasks.yml
> > +++ b/.cirrus.tasks.yml
> > @@ -627,6 +627,8 @@ task:
> > TEST_JOBS: 8
> > IMAGE: ghcr.io/cirruslabs/macos-runner:sonoma
> >
> > + XML_CATALOG_FILES: /opt/local/share/xml/docbook/4.5/catalog.xml
> > +
> > CIRRUS_WORKING_DIR: ${HOME}/pgsql/
> > CCACHE_DIR: ${HOME}/ccache
> > MACPORTS_CACHE: ${HOME}/macports-cache
> > @@ -641,6 +643,7 @@ task:
> >
> > MACOS_PACKAGE_LIST: >-
> > ccache
> > + docbook-xml-4.5
> > icu
> > kerberos5
> > lz4
>
> What is the reason for this change in this patch? AFAICT, your patch
> doesn't perform any XML-related operations anymore.

It is because of the "sgml_syntax_check" test in the meson build. This
test builds "postgres-full.xml" (same logic with make check) and the
build of "postgres-full.xml" has xmllint check. I could not find a way
to make this test optional like check target in the doc/src/sgml, so
the "sgml_syntax_check" test always runs.

Apart from this, I realized that there is a better way to create
"sgml_syntax_check". It was depending on "postgres-full.xml" before,
but now it directly builds the "postgres-full.xml" like "tmp_install"
test. This is addressed in the v8.

--
Regards,
Nazir Bilal Yavuz
Microsoft