| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: pgstattuple: Use streaming read API in pgstatindex functions |
| Date: | 2025-10-13 09:42:25 |
| Message-ID: | CAN55FZ3qjh1SKQ9bMg0pZTAbJ2jor4H1JUca=1YXxa8YgVX=-A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 13 Oct 2025 at 11:42, Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
>
> Here is patch v3. The comments have been added, and the extra scope
> ({}) has been removed as suggested.
Thanks, the code looks good to me!
The benchmark results are nice. I have a quick question about the
setup, if you are benchmarking with the default io_method (worker),
then the results might show the combined benefit of async I/O and
streaming I/O, rather than just streaming I/O alone. If that is the
case, I would suggest also running a benchmark with io_method=sync to
isolate the performance impact of streaming I/O. You might get
interesting results.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2025-10-13 09:59:36 | Re: Reorganize GUC structs |
| Previous Message | wenhui qiu | 2025-10-13 09:41:09 | Re: pgstattuple: Use streaming read API in pgstatindex functions |