Re: aio: Don't silently drop wait_event_info

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Yilin Zhang <jiezhilove(at)126(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: aio: Don't silently drop wait_event_info
Date: 2026-08-20 12:31:40
Message-ID: CAN55FZ3pCCOHvAeARY=3jE_qqpRDzy4fN-=ephOKduiMuRRTdg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for looking into this!

On Thu, 20 Aug 2026 at 14:32, Yilin Zhang <jiezhilove(at)126(dot)com> wrote:
>
> At 2026-08-20 18:56:32, "Nazir Bilal Yavuz" <byavuz81(at)gmail(dot)com> wrote:
>
> >One general place is PgAioHandle, I put wait_event_info into
> >PgAioHandle but now its size is increased from 144 to 152. I couldn't
> >find a better place, do you have any suggestions?
>
> Hi,
> I've reviewed your patch.
> I noticed that under the default io_method=worker,
> asynchronous reads from mdreadv still report AIO_IO_COMPLETION when the backend gets blocked.
> The caller‑supplied wait_event_info is still being ignored.
> Is this a problem?

I don't think it is a problem, these are two separate wait events,
reported by two different processes at the same time.

- AIO_IO_COMPLETION is reported when one backend (client backend for
example) is waiting IO to be done by someone else.

- wait_event_info (WAIT_EVENT_DATA_FILE_READ in this case) is used
when the actual backend doing the IO is waiting IO to be completed.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Ashutosh Sharma 2026-08-20 12:25:59 Re: Report bytes and transactions actually sent downtream