| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Aidar Imamov <a(dot)imamov(at)postgrespro(dot)ru>, Joseph Koshakow <koshy44(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache |
| Date: | 2025-08-08 10:17:45 |
| Message-ID: | CAN55FZ3k-52b3Vd=nZNg06fgmGaAoa4yDERVJ-AQXuxwGqP_qA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for looking into this! And sorry for the late reply.
On Fri, 16 May 2025 at 10:58, Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
>
> Hey,
>
> I noticed a couple of small clarity issues in the current version of patch for potential clean up:
>
> 1. Commit message wording
I changed the commit message. I made it very similar to the commit
message in dcf7e1697b.
> We currently have:
>
> PinBuffer_Locked(desc); /* releases spinlock */
>
> Folks who’re unfamiliar with this function might get confused. Maybe we could use the one in GetVictimBuffer:
>
>
> /* Pin the buffer and then release its spinlock */
>
> PinBuffer_Locked(buf_hdr);
>
>
> That spelling-out makes it obvious what’s happening.
I think this makes sense, this is done in v8 which is attached to the
email above.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-08-08 10:19:56 | Re: Datum as struct |
| Previous Message | Nazir Bilal Yavuz | 2025-08-08 10:16:57 | Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache |