| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ci: Generate crashlogs on Windows |
| Date: | 2026-06-10 15:54:00 |
| Message-ID: | CAN55FZ3X-PEwnzy_iW1yT9YoAb2u7bfKyoKsKV9_yrUg7rXd=g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for looking into this!
On Wed, 10 Jun 2026 at 16:49, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2026-06-10 15:59:20 +0300, Nazir Bilal Yavuz wrote:
> > +++ b/.github/actions/windows-setup-debugger/action.yml
> > @@ -0,0 +1,82 @@
> > +name: Setup Windows debugger
> > +description: >-
> > + Setup Windows debugger to log all crashes to
> > + <workspace>\crashlogs\crashlog-<pid-in-hex>.txt
> > +
> > +runs:
> > + using: composite
> > + steps:
> > + - name: Setup Windows debugger
> > + shell: pwsh
> > + run: |
> > + $crashdir = "${{ github.workspace }}/crashlogs"
> > + New-Item -ItemType Directory -Force -Path $crashdir
>
> Any reason to not just put this into src/tools/ci/<something>.ps1? Given that
> we're just talking about a single step, I don't really see the benefit of a
> composite action here.
Not any particular reason. I started implementing that in a pg-ci.yml,
then moved it to composite action when I realized it was too long. I
think having a script is better, so attached v2 uses that way.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-ci-Generate-crashlogs-on-Windows.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-06-10 16:08:54 | Re: Fix race during concurrent logical decoding activation |
| Previous Message | Ilia Evdokimov | 2026-06-10 15:50:33 | Show estimated number of groups for IncrementalSort in EXPLAIN |