Re: Improve error reporting in 027_stream_regress test

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve error reporting in 027_stream_regress test
Date: 2025-07-21 12:21:35
Message-ID: CAN55FZ3Of-mkK2TUO2P5R1Y6JsO4=NCFHa9+bZfOJDgaZ63mrA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sat, 19 Jul 2025 at 09:06, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> The structure is strange, it seems to me that we should target things
> so as we have only one PG_TEST_FILE_TRIM_LINES defined in the tree,
> not two with one local to 027.

I see your point. Then the problem is regression_log_helper() can't
check if $lines_to_dump * 2 is bigger than the number of lines in the
regression.diffs file. So, it can't decide whether or not to dump all
of the regression.diffs. Would it be okay if we repeat some lines in
both the head and tail lines?

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-07-21 12:39:48 Re: index prefetching
Previous Message Alexander Korotkov 2025-07-21 12:09:05 Re: Document slot's restart_lsn can go backward