Re: meson vs. llvm bitcode files

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Harrison Booth <harrisontbooth(at)gmail(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: meson vs. llvm bitcode files
Date: 2026-11-02 10:19:30
Message-ID: CAN55FZ3MWpX+6FddixNW7NEoYNnHVktsDzsbV060EPO3gxzsnw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, 20 Oct 2026 at 17:19, Harrison Booth <harrisontbooth(at)gmail(dot)com> wrote:
>
> Andres's patch + Nazir's four v15 patches are unchanged, followed by
> my same resource-file fix. The corrected 6-patch attachment addresses
> the packaging that the CFBot could not apply.
>
> All 6 patches apply to commits 6b3f8857aa83 & 0d110901f0ef with no
> issues. The five affected contrib files match the sources used for the
> focused resource/bitcode checks.
>
> This attachment is supported by tests of the resource-file fix. I
> haven't resolved the JIT testing at the server-level, and the
> experimental patches used for that testing aren’t included here.

I reproduced the problem with the Meson test (as I don't have Windows
with LLVM) and confirmed your patch fixes it. I added comments to it,
wrote a commit message and attached it as a separate patch. Thanks!

Some additional changes:

- I wrote commit messages for commits which don't have it.
- I reordered commits so that 'meson: Use .pc file as a standard
extension build interface' is the last commit now.

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v16-0001-meson-Add-postgresql-version-llvm-jit-bitcode.pc.patch text/x-patch 5.5 KB
v16-0002-meson-Add-docs-for-postgresql-version-llvm-jit-b.patch text/x-patch 5.2 KB
v16-0003-meson-Add-architecture-for-LLVM-bitcode-emission.patch text/x-patch 10.0 KB
v16-0004-meson-Add-LLVM-bitcode-emissions-for-contrib-lib.patch text/x-patch 3.2 KB
v16-0005-meson-Exclude-Windows-resources-from-contrib-bit.patch text/x-patch 4.0 KB
v16-0006-meson-Use-.pc-file-as-a-standard-extension-build.patch text/x-patch 7.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-11-02 10:34:04 Re: PostgreSQL 19 GA press release draft
Previous Message Jingtang Zhang 2026-11-02 10:13:33 Stale hash entries when reusing an auxiliary resource owner