From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Subject: | Re: Explicitly enable meson features in CI |
Date: | 2025-07-16 11:12:22 |
Message-ID: | CAN55FZ3LLNtcJYijGo1UJxJ1PBUF8txuPWphnrWAE0pxq=XVtg@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Thu, 10 Jul 2025 at 20:12, Jacob Champion
> <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> >
> > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> > > Andres off-list mentioned that if we explicitly enable features for
> > > *all* of the tasks, then none of the tasks will be testing the auto
> > > feature option and I agree with Andres. My suggestion is setting
> > > features to auto for Debian - Meson task. I decided on this because I
> > > think it is the most checked CI task
> >
> > Hehe, that's certainly true for me...
> >
> > > so it would be easier to catch if
> > > one of the features is disabled without anyone noticing.
> >
> > Seems reasonable. If we do this, can we rename the job with a "- Meson
> > Auto" suffix or something, to try to call the difference out
> > explicitly?
>
> I think renaming it would be better but then we have two Linux tasks:
>
> - Linux - Debian Bookworm - Autoconf
> - Linux - Debian Bookworm - Meson Auto
>
> For me it looks like 'Meson Auto' can be confused with 'Autoconf'. We
> can rename it as a 'Meson Auto Feature Detection' but that is a bit
> longer. Do you have any ideas? If you think 'Meson Auto' is good
> enough, we can continue with it, too.
I renamed 'Meson Auto' as 'Meson Auto Feature Detection' in v5.
--
Regards,
Nazir Bilal Yavuz
Microsoft
Attachment | Content-Type | Size |
---|---|---|
v5-0001-ci-Remove-PG_TEST_EXTRA-from-NetBSD-and-OpenBSD.patch | text/x-patch | 942 bytes |
v5-0002-ci-meson-Explicitly-enable-meson-features.patch | text/x-patch | 8.0 KB |
v5-0003-ci-meson-Store-common-Postgres-configuration-opti.patch | text/x-patch | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Nazir Bilal Yavuz | 2025-07-16 11:32:53 | Re: Improve error reporting in 027_stream_regress test |
Previous Message | Aleksander Alekseev | 2025-07-16 11:04:12 | Re: Missing NULL check after calling ecpg_strdup |