| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Improve docs syntax checking and enable it in the meson build |
| Date: | 2026-02-17 07:21:06 |
| Message-ID: | CAN55FZ30LvUxuBjqi0gJ+ekaG3VpYUhL=k5KaZwRn+5kvwyxLw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 17 Feb 2026 at 04:56, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Nazir,
>
> > I think we might be using different meson versions, which could
> > explain the difference. I am currently using meson v1.7.0.
>
> I verified on my two environments, and both could work as expected.
> Your patch was applied then doc/src/sgml/meson.build was updated
> from the HEAD.
Thank you for the quick testing! I’m able to reproduce the same
behavior on my Ubuntu machine using meson v1.3.2.
During my initial testing, I was using meson from the GitHub source by
cloning the repository and running meson.py from the repository root.
However, this setup didn’t allow me to test correctly because
'meson_bin = find_program(meson_binpath, native: true)' could not
locate the binary when using meson.py directly from the meson
repository. After correcting the path manually, I was able to
reproduce the behavior you described. Then, I confirmed that 'meson
test --suite doc' is problematic in meson v[1.7.0, 1.9.1], '--suite'
option triggers building the entire source tree whether you set
'depends: postgres_full_xml'.
Andres already reviewed the entire patch [1] and there are points
which can completely change the structure of the patch. I am planning
to address Andres' feedback first, and then revisit whether we still
need to add 'depends: postgres_full_xml'.
Thanks again for the report!
[1] https://postgr.es/m/nxszznj6nkdj2vh5cxvwzpwodsbtui6mqluxnur2y4x7xtkirw%40fbvhy54mluzl
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-02-17 07:26:29 | Re: Lowering the default wal_blocksize to 4K |
| Previous Message | Bertrand Drouvot | 2026-02-17 07:04:40 | Re: Flush some statistics within running transactions |