Re: Improve error reporting in 027_stream_regress test

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve error reporting in 027_stream_regress test
Date: 2025-07-21 08:53:00
Message-ID: CAN55FZ3-q0rp=gEg=M_UwQhJ1dWmCY30PdAXrnxPQcd1Uc__9Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sat, 19 Jul 2025 at 09:06, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> This one looks acceptable to me, so applied to begin with something,
> splitting things into two pieces for clarity with some tweaks. I have
> changed things to use system_log() at the end, with fat-commas to link
> the long options and their arguments.

Thanks!

I realized that we actually don't trim the file, we do the opposite;
read the file from both ends. Sorry for not realizing earlier. I will
update the remaining patches according to that but I think trim_file()
is helpful, too. What do you think about adding both

```
trim_file() -> trims $n lines from head or tail of the file and
returns the remaining lines.
read_file_ends() -> returns $n lines from head or tail of the file.
```

although trim_file() will not be used in these particular patches?

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-07-21 08:57:41 Re: sql/json query function JsonBehavior default expression's collation may differ from returning type's collation
Previous Message vignesh C 2025-07-21 08:52:53 Re: Logical Replication of sequences