Re: Use streaming read I/O in BRIN vacuuming

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use streaming read I/O in BRIN vacuuming
Date: 2025-10-13 07:24:38
Message-ID: CAN55FZ2oB732zD1ORYJDOHyA862NQhfjp3kTYHkqA8d_FEMB5w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 9 Oct 2025 at 02:03, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Thank you for proposing the patch! I've reviewed the patch and have
> some comments:
>
> + stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE |
> + READ_STREAM_FULL |
> + READ_STREAM_SEQUENTIAL |
> + READ_STREAM_USE_BATCHING,
> + strategy,
> + idxrel,
> + MAIN_FORKNUM,
> + block_range_read_stream_cb,
> + &p,
> + 0);
>
> Unlike other index AM's it uses READ_STREAM_SEQUENTIAL. If there are
> some reasons to use it, we should leave comments there.

Andres has some comments about retiring the READ_STREAM_SEQUENTIAL
flag as it is automatically detected and can potentially hurt
performance [1].

[1] https://postgr.es/m/go7c2sudqg4pp7dsabsak4ajugti4f3tyqoweja5ihcjiw65dc%40yh6wi4zqys23

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-10-13 07:27:38 Re: Logical Replication of sequences
Previous Message Chao Li 2025-10-13 07:24:27 Re: commit_baseurl is broken in postgres.sgml