Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Aidar Imamov <a(dot)imamov(at)postgrespro(dot)ru>, Joseph Koshakow <koshy44(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions
Date: 2025-04-11 08:01:21
Message-ID: CAN55FZ2diJD0bTYDDbM+WRCh-h_PYp_3bZYUGLvzy52acCD4wA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 10 Apr 2025 at 16:50, Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> On Tue, Apr 08, 2025 at 02:40:52AM -0400, Andres Freund wrote:
> > I think it's ok for now. It might be worth doing a larger redesign of the
> > pgbuffercache docs at some point...
> >
> >
> > Pushed.
> >
> >
> > Thanks for your patches and thanks for all the reviewers getting this ready!
>
> Thanks for the patch! That sounds like a great addition. I was doing some
> tests and did not see any issues.

Thank you for looking into this!

> Also while doing the tests I thouhgt that it
> could be useful to evict only from a subset of NUMA nodes (now that NUMA
> awareness is in). We'd need to figure out what to do for buffers that are spread
> across NUMA nodes though.
>
> Does that sound like an idea worth to spend time on? (If so, I'd be happy to work
> on it).

I think it looks useful, but I’m not too familiar with NUMA, so I’m
not sure I can say much with confidence. Maybe someone else can chime
in with a more solid take?

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2025-04-11 08:02:28 Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions
Previous Message Hayato Kuroda (Fujitsu) 2025-04-11 07:53:07 Regression test fails when 1) old PG is installed and 2) meson/ninja build is used