Re: Explicitly enable meson features in CI

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Explicitly enable meson features in CI
Date: 2025-08-26 07:27:27
Message-ID: CAN55FZ2UW7iuK5phB-sjQmidJp0mTwk-Sqhg3b7z5HMtxxcZTQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, 26 Aug 2025 at 02:37, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Mon, Jul 28, 2025 at 11:20 AM Jacob Champion
> <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> > Sounds good. I will take another look at this with a committer hat and
> > push Sometime Soon.
>
> Getting back to this -- for v7 I've rebased over the FASTLINK commit.
> I've squashed 0002 and 0003 together, too -- I think it's easier to
> see the new envvar hierarchy in one commit.
>
> I also moved the `-Dnls=disabled` setting into a mingw-specific
> MESON_FEATURES variable. I think the existing comment in v6 wasn't
> really in a place to prevent a developer from adding it to
> MESON_COMMON_FEATURES in the future, which would have regressed
> 967db242c. There shouldn't be a hazard now.

Thank you for doing these!

Patches LGTM. I also checked the CI tasks and everything looks good.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2025-08-26 07:41:53 Detoast iterators -take 2
Previous Message Alyona Vinter 2025-08-26 07:12:20 Re: Making WAL archiving faster — multi-file support and async ideas