| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | KAZAR Ayoub <ma_kazar(at)esi(dot)dz> |
| Cc: | Mark Wong <markwkm(at)gmail(dot)com>, Neil Conway <neil(dot)conway(at)gmail(dot)com>, Manni Wood <manni(dot)wood(at)enterprisedb(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speed up COPY FROM text/CSV parsing using SIMD |
| Date: | 2026-02-03 11:02:16 |
| Message-ID: | CAN55FZ2PD5ZuvcrJPzZhZ==VDYPVwrPKNqbeDsiA4NKncrzn1g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for all your help!
This thread has a couple of discussions and it can be hard to follow;
I think it would be better if we can separate these discussions. This
would make it easier to follow the topics. What I have in my mind is:
* There are four patches in this thread, three of them COPY FROM
related: v3, v4 and v5. One of them is COPY TO related. So, I guess it
would be better to move COPY TO discussion to another thread.
* Manni suggested to stop benchmarking v4.2 COPY FROM patch, I agree
with him. Then it would be easier to address reviews and do
benchmarking.
* Kazar applied Neil's review on top of v3 and benchmarked, v3 seems
to perform better but I think flushing line_buf needs more
benchmarking.
* I am planning to create a new version (v6) of the patch, which will
be basically v3 with one less branching (moving !in_quote check under
is_csv and else). So that it would be easy to review and follow the
thread for new reviewers.
What do you think about these? Do you think these make sense and / or
do you have any other suggestions?
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-02-03 11:02:50 | Re: Non-deterministic buffer counts reported in execution with EXPLAIN ANALYZE BUFFERS |
| Previous Message | Nazir Bilal Yavuz | 2026-02-03 10:59:52 | Re: Speed up COPY FROM text/CSV parsing using SIMD |