| From: | Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup shadows variable warnings, round 1 |
| Date: | 2025-12-04 13:04:07 |
| Message-ID: | CAN55FZ2M3J38q6PpPjuD-SjxiFDLn-80nR6Xj=kf4vU4h3rHgA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 4 Dec 2025 at 14:21, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Dec-04, Chao Li wrote:
>
> > The motivation is that CF’s CI currently fails on shadow-variable warnings.
> > If you touch a file like a.c, and that file already has a legacy shadowing
> > issue, CI will still fail your patch even if your changes are correct. Then
> > you’re forced to fix unrelated shadow-variable problems just to get a clean
> > CI run. I’ve run into this myself, and it’s disruptive for both patch
> > authors and reviewers.
>
> Hmm, maybe that should be turned off. It sounds seriously unhelpful.
To test that I created this CI run [1], which edits the brin.c file.
That file has a legacy shadowing issue but the CI did not fail. Could
you please show an example CI run?
[1] https://cirrus-ci.com/build/5444936843132928
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Amul Sul | 2025-12-04 12:46:50 | Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions |