| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | walther(at)technowledgy(dot)de |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Building with meson on NixOS/nixpkgs |
| Date: | 2024-04-01 10:55:45 |
| Message-ID: | CAN55FZ2J=+bvMtzq18hsf=-FJdWzJo20gqLgO=nMLd3=W8Fudg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
From your prior reply:
On Thu, 21 Mar 2024 at 23:44, Wolfgang Walther <walther(at)technowledgy(dot)de> wrote:
>
> Nazir Bilal Yavuz:
> > 0001 & 0002: Adding code comments to explain why they have fallback
> > could be nice.
> > 0003: Looks good to me.
>
> Added some comments in the attached.
Comments look good, thanks.
On Fri, 29 Mar 2024 at 21:48, <walther(at)technowledgy(dot)de> wrote:
>
> In v3, I added another small patch for meson, this one about proper
> handling of -Dlibedit_preferred when used together with -Dreadline=enabled.
You are right. I confirm the bug and your proposed patch fixes this.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-04-01 11:06:12 | Re: Popcount optimization using AVX512 |
| Previous Message | walther | 2024-04-01 10:55:37 | Re: Security lessons from liblzma |