| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: locale / encoding / meson cleanup |
| Date: | 2026-08-26 14:08:27 |
| Message-ID: | CAN55FZ26+ZmYaL4+wQnN0ZgTzq8jRXG-yVcfO7k2fcdZcPw0Lg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for working on this!
I reviewed this patch with GPT's help and confirmed that some findings
are relevant.
On Sun, 23 Aug 2026 at 16:01, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> 2. collate.linux.utf8 has never run on a meson build
>
> infinite_recurse is the other test that matches on the platform string,
> and it
> gets it the other way round: it means to skip itself on ppc64 Linux
> because of
> a kernel bug, and on a meson build the match will never fire, so it will be
> running the case it's meant to stay away from. I don't have a ppc64
> machine to
> confirm that end of it, so that part is a reading of the code rather than
> something I've observed.
It seems meson returns 'ppc64' [1].
> 0004 makes the meson build report the GNU host triplet, by asking the
> compiler
> for it with -dumpmachine where it supports that and falling back to the
> present
> behaviour otherwise.
+host_tuple = '@0(at)-@1@'.format(host_machine.cpu_family(), host_system)
+if cc.get_id() in ['gcc', 'clang']
+ dumpmachine = run_command(cc.cmd_array(), '-dumpmachine', check: false)
I think we need to add c_args here, like:
dumpmachine = run_command(
cc.cmd_array() + get_option('c_args'), '-dumpmachine', check: false)
There could be a '--target' in the c_args which might affect the result [2].
[1] https://mesonbuild.com/Reference-tables.html#cpu-families
[2] https://clang.llvm.org/docs/ClangCommandLineReference.html
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-08-26 14:11:16 | Re: scary patch contest |
| Previous Message | Nathan Bossart | 2026-08-26 14:05:03 | Re: scary patch contest |