| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make -C src/test/isolation failure in index-killtuples due to btree_gist |
| Date: | 2025-11-17 15:45:30 |
| Message-ID: | CAN55FZ25NO86hpRoZ+vNNpzLU=7TBPg+i92qj+y16Dx0ZhBtig@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, 31 Oct 2025 at 03:42, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Oct 30, 2025 at 11:24:55AM -0400, Andres Freund wrote:
> > Well, it tests multiple index types, not just gist. I guess
> > test/modules/indexes/ or so should work? Not sure about plural or not.
>
> test/modules/index/ would work here. If you feel strongly about being
> able to do an EXTRA_INSTALL in src/test/isolation/, I have no
> objections to that as that would also solve the original problem if
> that's the consensus. My personal choice would be a test module for
> that, as it feels cleaner.
I have two patches to implement this: one moving the killtuples test
under test/modules/index/, and another adding coverage for the
recovery path.
0001 moves killtuples test under the test/modules/index/ without any
implementation change.
0002 converts the killtuples isolation test to a TAP test to exercise
the recovery path. This patch sets up a standby and additionally
re-inserts into the table while testing the GiST index to ensure
coverage of the gistRedoDeleteRecord() function.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Move-index-killtuples-test-to-test-modules-index.patch | text/x-patch | 4.5 KB |
| v1-0002-Convert-killtuples-isolation-test-to-TAP-test.patch | text/x-patch | 37.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-11-17 16:35:46 | Re: POC: make mxidoff 64 bits |
| Previous Message | Ilia Evdokimov | 2025-11-17 15:42:38 | Re: Use merge-based matching for MCVs in eqjoinsel |