Re: Building with meson on NixOS/nixpkgs

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Wolfgang Walther <walther(at)technowledgy(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Building with meson on NixOS/nixpkgs
Date: 2024-03-18 12:25:58
Message-ID: CAN55FZ20xWGdj1KnQJ20TsnXHy2Tgbxmp82Ci8RvHktOyJ_GSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for the patches!

On Sat, 16 Mar 2024 at 14:48, Wolfgang Walther <walther(at)technowledgy(dot)de> wrote:
>
> To build on NixOS/nixpkgs I came up with a few small patches to
> meson.build. All of this works fine with Autoconf/Make already.

I do not have NixOS but I confirm that patches cleanly apply to master
and do pass CI. I have a small feedback:

0001 & 0002: Adding code comments to explain why they have fallback
could be nice.
0003: Looks good to me.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-03-18 12:57:34 Re: Possibility to disable `ALTER SYSTEM`
Previous Message Daniel Gustafsson 2024-03-18 12:11:41 Re: Reducing connection overhead in pg_upgrade compat check phase