From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: split func.sgml to separated individual sgml files |
Date: | 2025-10-01 12:27:52 |
Message-ID: | CAN55FZ1hzAmvGb=JoSFtz1mwRseXe-7jW31Ouvx_qAOoRS3CHg@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Wed, 1 Oct 2025 at 15:09, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> On Tue, 30 Sept 2025 at 22:48, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >
> > Hi Bilal,
> >
> > This got preempted slightly by Tom's commit 170a8a3f460, but I think
> > it's worth doing. I tried to simplify it some. See attached. There
> > doesn't seem to me to be any point in using a different set of files for
> > the tab tests and the NBSP tests. If we use the same set of files we can
> > improve the efficiency easily by opening them only once. Here we just
> > look for all the sgml files and all the xsl files and process them all.
> >
> > WDYT?
>
> It looks good to me. I made 2 changes to your patch:
>
> 1- Declaration of $line_no is lost, I re-added it.
> 2- s/.cirrus.tasks,yml/.cirrus.tasks.yml/ in the commit message.
Two more minor changes that I missed in the v2:
1- I added $line_no and removed $_ from the tab check's warning
message. I think it is better this way, otherwise if the line only
contains tab character; $_ will print an empty looking line.
2- s/Tabsand/Tabs and/
--
Regards,
Nazir Bilal Yavuz
Microsoft
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Improve-docs-syntax-checking.patch | text/x-patch | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2025-10-01 12:40:26 | Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL |
Previous Message | Hayato Kuroda (Fujitsu) | 2025-10-01 12:27:25 | RE: Patch for migration of the pg_commit_ts directory |