Re: ci: Improve OpenBSD core dump backtrace handling

Hi,

Thank you for looking into this!

On Sat, 25 Oct 2025 at 00:41, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Sat, Oct 25, 2025 at 2:20 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> > Any feedback would be appreciated.
>
> + filename=$(basename "$corefile")
> + base=$(echo "$filename" | sed 's/\.core.*$//')
> + binary=$(find "$executable_directory" -type f -name "$base"
> 2>/dev/null | head -n 1)
> +
> + if [ -z "$binary" ]; then
> + echo "${base} executable can not be found in
> ${executable_directory}"
> + continue
> + fi
> +
> + lldb "$binary" -c "$corefile" --batch -o 'thread backtrace
> all' -o 'quit'
>
> s/can not/cannot/, I don't make the rules...
>
> Maybe if not found it should just run it the old way without the
> executable? We don't really expect other programs to be dumped (well,
> sometimes we abort cp etc, something I plan to fix...), and they're
> probably stripped anyway, but I guess we might as well try to show as
> much information as we can if it happens? Would it be better to set
> PATH to $executable_directory:$PATH and use "which"?

I agree with all of your points. All of them are addressed in the v2.

--
Regards,
Nazir Bilal Yavuz
Microsoft