| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written} |
| Date: | 2023-10-03 09:37:37 |
| Message-ID: | CAN55FZ1T0NnuS-OWKsN-Akynm3d_BvnnE7g9dQpvX1EaKRnLjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, 15 Sept 2023 at 16:30, Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Yes, good catch. This is a bug. I will note that at least in 15 and
> likely before, pgBufferUsage.local_blks_written is incremented for
> local buffers but pgBufferUsage.blk_write_time is only added to for
> shared buffers (in FlushBuffer()). I think it makes sense to propose a
> bug fix to stable branches counting blk_write_time for local buffers
> as well.
I attached the PG16+ (after pg_stat_io) and PG15- (before pg_stat_io)
versions of the same patch.
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-PG16-Add-pgBufferUsage.blk_write_time-to-for-IOOp.patch | application/x-patch | 953 bytes |
| v2-0001-PG16-Increase-pgBufferUsage.blk_-read-write-_time.patch | application/x-patch | 1.3 KB |
| v2-0002-PG15-Add-pgBufferUsage.blk_write_time-to-for-exte.patch | text/x-diff | 1.8 KB |
| v2-0001-PG15-Add-pgBufferUsage.blk_write_time-to-for-loca.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-10-03 09:40:26 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Ashutosh Bapat | 2023-10-03 09:32:58 | Re: Doc: Minor update for enable_partitionwise_aggregate |