Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade
Date: 2025-09-15 08:50:07
Message-ID: CAN55FZ1KKMCm9uzOycNSFQa9FbCtdJiZsctZ8far_PvpxrzHsg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 11 Sept 2025 at 17:55, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Thu, Sep 11, 2025 at 7:18 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> > I don't think we need this level of complication. We already have the
> > situation that for example "linux" covers several tasks
>
> Recently, I've wished that it were otherwise; if I'm debugging a
> Meson-only test failure in Linux, I don't want to burn credits running
> Autoconf.

I agree with Jacob. I think it would be better if each task had its
own tag. I left it as "vs2019" for now. Also, one problem is that if
we use "windows" for both tasks; then we need to use the
"CI_TRIGGER_TYPE_WINDOWS" variable to make VS 2019 task manually
triggered. However, we should not use this variable in the VS 2022
task because it will be triggered automatically. I think this causes a
bit of confusion.

The PR [1] for 'installing both VS 2022 and VS 2019 to the Windows CI
image' is merged. VS 2019 installation is set to default installation
on the Windows CI image. VS 2022 was the default installation when the
PR was created but then we switched to VS 2019 to be able to commit
this patch any time without depending on the PR.

v3 is attached. I forgot to update the MinGW task's name in the
previous versions, it is done now.

Example CI task: https://cirrus-ci.com/build/4811555264528384

[1] https://github.com/anarazel/pg-vm-images/pull/116

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v3-0001-ci-Fix-Windows-and-MinGW-tasks-namings.patch text/x-patch 1.1 KB
v3-0002-ci-windows-Default-to-VS-2022-run-VS-2019-task-ma.patch text/x-patch 2.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Yurichev 2025-09-15 09:04:26 Re: someone else to do the list of acknowledgments
Previous Message Aleksander Alekseev 2025-09-15 08:40:19 Re: [PATCH] Refactor bytea_sortsupport(), take two