| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: slightly misleading Error message in guc.c |
| Date: | 2024-04-22 14:08:05 |
| Message-ID: | CAN55FZ1=aNRLAy=AwTTC-cV_PJZfUQr745aewRiAryKQJZ22aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 22 Apr 2024 at 11:44, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
> minor issue in guc.c.
>
> set work_mem to '1kB';
> ERROR: 1 kB is outside the valid range for parameter "work_mem" (64
> .. 2147483647)
> should it be
> ERROR: 1 kB is outside the valid range for parameter "work_mem" (64
> kB .. 2147483647 kB)
> ?
> since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}
>
> search `outside the valid range for parameter`,
> there are two occurrences in guc.c.
Nice find. I agree it could cause confusion.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-04-22 14:17:19 | Re: allow changing autovacuum_max_workers without restarting |
| Previous Message | Robert Haas | 2024-04-22 13:53:41 | Re: pg_combinebackup does not detect missing files |