| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: aio: Don't silently drop wait_event_info |
| Date: | 2026-08-20 10:56:32 |
| Message-ID: | CAN55FZ0Vo4JD2Ya52Q_Za+T9eSvcBpFDRV9ezi6b9B6N_robJQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for looking into this!
On Wed, 19 Aug 2026 at 16:27, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2026-08-19 13:31:28 +0300, Nazir Bilal Yavuz wrote:
> >
> > Fix this by storing the wait event in PgAioOpData and reporting it.
>
> I don't think that's quite the right fix though - PgAioOpData is for data that
> differs between operations, but it seems this is something that's relevant
> across all of the eventually supported operations. So I think it should be
> implemented in a more generic place?
One general place is PgAioHandle, I put wait_event_info into
PgAioHandle but now its size is increased from 144 to 152. I couldn't
find a better place, do you have any suggestions?
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-aio-Don-t-silently-drop-wait_event_info.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Jadhav | 2026-08-20 11:03:32 | Re: pg_dump: assert failure sorting casts/transforms |
| Previous Message | Andrey Borodin | 2026-08-20 10:49:49 | Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row |