Re: ci: Macos failures due to MacPorts behaviour change

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ci: Macos failures due to MacPorts behaviour change
Date: 2024-11-27 13:33:02
Message-ID: CAN55FZ09E97RT_9aO3eb3LJEv=RCd0n0_aahe88A9LJjLcgD8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 22 Nov 2024 at 20:28, Andres Freund <andres(at)anarazel(dot)de> wrote:
> The right approach probably is to include the list of packages in the key. A
> bit annoying to change, because we'd need to move the list of packages to an
> environment variable or file, but doable. I think something like
>
> env:
> MACOS_PACKAGE_LIST: >-
> ccache
> icu
> ...
> fingerprint_script: |
> ...
> echo $MACOS_PACKAGE_LIST
> ...
> setup_additional_packages_script: |
> sh src/tools/ci/ci_macports_packages.sh $MACOS_PACKAGE_LIST
>
> should work?

I think this is a nice solution and it worked successfully [1]. Now,
REL_[17 | 16]_* and master branches use the same cache which is
different from the REL_15_STABLE branch's cache.

In case you want to continue with this, the patches are attached. I
merged 'using a loop in the install script' from Thomas' patch and the
change above.

[1] First run - second run (See cache is used in the second run.)
[Master] https://cirrus-ci.com/task/6398434171682816 -
https://cirrus-ci.com/task/6460963865493504
[PG 16] https://cirrus-ci.com/task/5697896752873472 -
https://cirrus-ci.com/task/4656279002546176
[PG 15] https://cirrus-ci.com/task/5192066743926784 -
https://cirrus-ci.com/task/5033544097988608

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v3-0001-ci-PG-17-16-Fix-cached-MacPorts-installation-mana.patch text/x-patch 3.7 KB
v3-0001-ci-PG-15-Fix-cached-MacPorts-installation-managem.patch text/x-patch 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-11-27 13:33:58 Re: Difference in dump from original and restored database due to NOT NULL constraints on children
Previous Message Alena Rybakina 2024-11-27 13:22:38 Re: Showing primitive index scan count in EXPLAIN ANALYZE (for skip scan and SAOP scans)